[ 
https://issues.apache.org/jira/browse/PDFBOX-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390013#comment-15390013
 ] 

John Hewson edited comment on PDFBOX-3353 at 7/22/16 6:39 PM:
--------------------------------------------------------------

The protected methods which Tilman mentioned and the constructors are new 
public API surface area. In general we've seen that users will inherit from 
core PDFBox classes to fix bugs and then never contribute back and complain 
when we fix the bugs in a way which breaks their subclass - so unless there's a 
very good reason to subclass PDAbstractContentStream, it shouldn't be possible.

I don't think it's really necessary to split PDPageContentStream into three 
classes (though we'd need to think through exactly what a good solution looks 
like), so we can most likely just avoid the whole issue.


was (Author: jahewson):
The protected methods which Tilman mentioned and the constructors are new 
public API surface area. In general we've seen that users will inherit from 
core PDFBox classes to fix bugs and then never contribute back and complain 
when we fix the bugs in a way which breaks their subclass - so unless there's a 
very good reason to subclass PDAbstractContentStream, it shouldn't be possible.

> Create appearance streams for annotations
> -----------------------------------------
>
>                 Key: PDFBOX-3353
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3353
>             Project: PDFBox
>          Issue Type: Task
>          Components: PDModel, Rendering
>    Affects Versions: 1.8.12, 2.0.0, 2.0.1, 2.0.2, 2.1.0
>            Reporter: Tilman Hausherr
>              Labels: Annotations
>         Attachments: SquareAnnotations.pdf, showAnnotation.java
>
>
> Create appearance streams for annotations when missing.
> I'll start by replacing current code for Ink and Link annotations.
> Good example PDFs:
> http://www.pdfill.com/example/pdf_commenting_new.pdf
> https://github.com/mozilla/pdf.js/issues/6810



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to