[
https://issues.apache.org/jira/browse/PDFBOX-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390513#comment-15390513
]
Daniel Persson commented on PDFBOX-3353:
----------------------------------------
Hi John
Just had to comment on your last comment. The reasoning for not making a class
inheritable is a solid on at first glans but might have consequences.
When you make a class private / protected you lock down that class and those
who need a quick fix could realize this and try to work around it. In the worst
case someone might have to have a dummy subsystem to change one value that the
author won't change for some reason.
So using a third party library can be annoying for many reasons. A good API is
extendable and open.
If you get complaints when you bugfix that seems more like a community problem
than a code problem.
It's hard to measure the tone of text when English isn't your native language,
but I hope you read my message as a reflection on your comment and not
criticism.
This community has made a great tool that I'm happy to use and contribute.
Best regards
Daniel
> Create appearance streams for annotations
> -----------------------------------------
>
> Key: PDFBOX-3353
> URL: https://issues.apache.org/jira/browse/PDFBOX-3353
> Project: PDFBox
> Issue Type: Task
> Components: PDModel, Rendering
> Affects Versions: 1.8.12, 2.0.0, 2.0.1, 2.0.2, 2.1.0
> Reporter: Tilman Hausherr
> Labels: Annotations
> Attachments: SquareAnnotations.pdf, showAnnotation.java
>
>
> Create appearance streams for annotations when missing.
> I'll start by replacing current code for Ink and Link annotations.
> Good example PDFs:
> http://www.pdfill.com/example/pdf_commenting_new.pdf
> https://github.com/mozilla/pdf.js/issues/6810
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
