[ 
https://issues.apache.org/jira/browse/PDFBOX-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715714#comment-15715714
 ] 

Tilman Hausherr edited comment on PDFBOX-3000 at 12/2/16 6:52 PM:
------------------------------------------------------------------

The last commit was developed by debugging the rendering of 
PDFJS-5811-2-p3_reduced4.pdf which has two nested transparency groups, none of 
which start at (0,0). After doing the upper change ({{new PDRectangle(...}}), 
many files were improved but some black rectangles started to appear in some 
files, and a mysterious vertical line appeared in the middle of a less reduced 
version, PDFJS-5811-2-p3_reduced.pdf, which has a softmask. Zooming in on that 
one showed some grey that was at about 1/2 of the square, at 38 units, which is 
the offset of the outer transparency group. That one gave it away that the 
softmask was also wrong by an offset, and this resulted in the second change, 
in getBounds(). This fixed quite a lot of files.

And I'm also learned something: colors at wrong position => transparency 
problem. Black squares, shadows at wrong position => softmask problem.

Improved files ("probably perfect" means that the file is too complex to tell):
- bugzilla-852992.pdf: color change is back, but not perfect
- ds-firewall-enterprise-p1.pdf: perfect, cables visible
- gs-bugzilla686747.ai: probably perfect, gradient masking of lower happy 
birthday now there
- gs-bugzilla688601.pdf: perfect
- gs-bugzilla689095.pdf: mostly perfect, inside of "verso" visible
- gs-bugzilla689918-veryslow.pdf: probably perfect, star is shining
- gs-bugzilla690351-p10.pdf: probably perfect, shadows correct
- gs-bugzilla690535.pdf: euro visible, although not in gold
- gs-bugzilla691182.pdf: perfect, car and shadow correct
- gs-bugzilla691218.pdf: improved, shadow below SONATA
- gs-bugzilla694556-3.pdf: perfect, shadows correct
- gs-bugzilla694585.pdf: probably perfect, blue ball is back
- gs-bugzilla695354.pdf: perfect, shadows correct
- gs-bugzilla697350.pdf: perfect
- PDFBOX-1058.pdf: probably perfect, fine lines are back
- PDFBOX-3494.pdf: perfect, shadow correct
- PDFBOX-3501.pdf: perfect, background colors now visible
- PDFJS-1324-2012_visitorsguide_web.pdf p4: perfect, "under construction" 
watermark visible; p3: footprints visible
- PDFJS-4735.pdf: probably perfect, dancers are back
- PDFJS-5811-2.pdf: p2: perfect, shadows on boxes; p3: perfect, squares at 
correct position
- PDFJS-6113.pdf: probably perfect, "Fukayuki-rinkan" now visible
- PDFJS-6967.pdf: perfect, lower right image visible

Changed files:
- gs-bugzilla688870.pdf
- PDFJS-3096.pdf: shadows below smartphones visible, rest still bad

Worsened files:
- bugzilla869140.pdf: girls room no longer pink
- gs-bugzilla692217.pdf: shadows at wrong position

Of those about which I complained in PDFBOX-2423, there are only two left that 
don't render like in 1633472. However there are others I found later so there's 
still work to do. I'll keep creating reduced files and debug from there.

I'm not yet ready to transfer the changes to the 2.0 branch, I prefer to solve 
the obvious problems first. Examples:
- gs-bugzilla689309-1.pdf
- gs-bugzilla691537.pdf



was (Author: tilman):
The last commit was developed by debugging the rendering of 
PDFJS-5811-2-p3_reduced4.pdf which has two nested transparency groups, none of 
which start at (0,0). After doing the upper change ({{new PDRectangle(...}}), 
many files were improved but some black rectangles started to appear in some 
files, and a mysterious vertical line appeared in the middle of a less reduced 
version, PDFJS-5811-2-p3_reduced.pdf, which has a softmask. Zooming in on that 
one showed some grey that was at about 1/2 of the square. That one gave it away 
that the softmask was also wrong by an offset, and this resulted in the second 
change, in getBounds(). This fixed quite a lot of files.

And I'm also learned something: colors at wrong position => transparency 
problem. Black squares, shadows at wrong position => softmask problem.

Improved files:
- bugzilla-852992.pdf: color change is back, but not perfect
- ds-firewall-enterprise-p1.pdf: perfect, cables visible
- gs-bugzilla686747.ai: probably perfect, gradient masking of lower happy 
birthday now there
- gs-bugzilla688601.pdf: perfect
- gs-bugzilla689095.pdf: mostly perfect, inside of "verso" visible
- gs-bugzilla689918-veryslow.pdf: probably perfect, star is shining
- gs-bugzilla690351-p10.pdf: probably perfect, shadows correct
- gs-bugzilla690535.pdf: euro visible, although not in gold
- gs-bugzilla691182.pdf: perfect, car and shadow correct
- gs-bugzilla691218.pdf: improved, shadow below SONATA
- gs-bugzilla694556-3.pdf: perfect, shadows correct
- gs-bugzilla694585.pdf: probably perfect, blue ball is back
- gs-bugzilla695354.pdf: perfect, shadows correct
- gs-bugzilla697350.pdf: perfect
- PDFBOX-1058.pdf: probably perfect, fine lines are back
- PDFBOX-3494.pdf: perfect, shadow correct
- PDFBOX-3501.pdf: perfect, background colors now visible
- PDFJS-1324-2012_visitorsguide_web.pdf p4: perfect, "under construction" 
watermark visible; p3: footprints visible
- PDFJS-3096.pdf: shadows below smartphones visible, rest still bad
- PDFJS-4735.pdf: probably perfect, dancers are back
- PDFJS-5811-2.pdf: 
XXXX

Changed files:
- gs-bugzilla688870.pdf


Worsened files:
- bugzilla869140.pdf: girls room no longer pink
- gs-bugzilla692217.pdf: shadows at wrong position


> Transparency Group issues
> -------------------------
>
>                 Key: PDFBOX-3000
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3000
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Rendering
>    Affects Versions: 2.0.0
>            Reporter: John Hewson
>             Fix For: 2.1.0
>
>         Attachments: 007087-payment-due-p58_reduced2.pdf, 
> PDFBOX-1697-reduced-rotations.pdf, PDFBOX-2182_mod.pdf, PDFBOX-3400-RGB.pdf, 
> PDFBOX-3494_reduced.pdf, PDFBOX-3494_reduced_cropX.pdf, PDFBOX-3564-Mask.pdf, 
> PDFBox3359PanelTestEnhanced.java, PDFJS-2845-p1.pdf, 
> PDFJS-5811-2-p3_reduced.pdf, PDFJS-5811-2-p3_reduced4.pdf, 
> PDFJS-5811-2-p4_reduced-rotations.pdf, PDFJS-5811-2.pdf, 
> PDFJS-5853_reduced.pdf, ds-firewall-enterprise-p1_reduced.pdf, 
> gs-bugzilla691157.pdf, gs-bugzilla691157_mod_unc.pdf, 
> gs-bugzilla691157_mod_unc.png, gs-bugzilla691348.pdf, 
> gs-bugzilla693322_reduced.pdf, gs-bugzilla694556-3.pdf, 
> gs-bugzilla695354.pdf, gs-bugzilla695582-transparency-fill-stroke.pdf, 
> gs-bugzilla695582-transparency-fill-stroke.pdf-1.png, 
> samsung_galaxy_s_4_um-p1_reduced.pdf, softmask-rewrite-alt1.patch, 
> softmask-rewrite.patch
>
>
> This is a follow-up issue for transparency group issues from PDFBOX-2423. 
> More details to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to