I have read about this concept "don't use null, return empty list instead" often and I like it... I haven't changed anything here because I'm always wondering whether there could be a case where we want to know whether the object is missing, or when we write back the object and a PDF would then have an empty object instead of nothing at all.

Tilman

Am 17.01.2018 um 18:41 schrieb Maruan Sahyoun:
Hi,

many of our methods return null in case an entry can not be found potentially 
causing NPEs. For 3.0 what about starting to change that so we return the 
expected object in the PDModel although I understand that this might mean that 
for some time some methods might return null where others might return the 
expected object.

E.g. in PDAnnotationTextMarkup.getQuadPoints() in the unlikely case that there 
is no sufficient entry instead of return null we could return an empty float[].

Wouldn't expect that we start looking for such cases but doing it as we touch 
methods.

WDYT?

BR
Maruan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to