[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392659#comment-16392659 ]
Maruan Sahyoun commented on PDFBOX-4071: ---------------------------------------- I've added a {{SupressWarnings}} annotation to disable a false check by Sonar. IMHO that's a clean approach to do it this way instead of disabling a rule in Sonar as the source comment can be specific. OTOH we add tools specific information to our source which might not be ideal. But as we decided for Sonar I think that's tolerable. I specifically picked this one to show a possibility to handle a warning where Sonar is definitely wrong. Please let me know if you don't like the approach. > Improve code quality (3) > ------------------------ > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task > Affects Versions: 2.0.8 > Reporter: Tilman Hausherr > Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org