[ 
https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405110#comment-16405110
 ] 

Gary Potagal commented on PDFBOX-4158:
--------------------------------------

Hi, changed the attached image:  
https://issues.apache.org/jira/secure/attachment/12915154/BiggestObjectAllocationGraph.png
 to show full picture.

I was going to catch  Throwable, log at WARN and throw IOException with the 
count of errors, something like "Encountered N errors in attempt to close m 
documents", but I can re-throw first Exception if you prefer.

Will take about a week to complete and validate in our test environment. 

Thanks! 

> COSDocument and PDFMerger may not close all IO resources if closing of one 
> fails
> --------------------------------------------------------------------------------
>
>                 Key: PDFBOX-4158
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4158
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 2.0.4, 2.0.9, 3.0.0 PDFBox
>            Reporter: Maruan Sahyoun
>            Priority: Minor
>         Attachments: BiggestObjectAllocationGraph.png, BiggestObjectList.png
>
>
> As observed on the users mailing list  {{COSDocument.close}} and 
> {{PDFMergerUtility.mergeDocuments}} might not close all IO resources if 
> closing of one of the resources fails



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to