[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406795#comment-16406795 ]
Tilman Hausherr edited comment on PDFBOX-4071 at 3/20/18 6:07 PM: ------------------------------------------------------------------ {quote} Tilman Hausherr Would you mind reviewing the warning "Introduce a new variable instead of reusing the parameter "subsampling" for lines 234, 346, 421 in SampledImageReader? Sonar doesn't like reassigning method parameter values. {quote} Will do but after I've done the pending change (PDFBOX-4156) to avoid the patch getting invalid and me having extra work. I will commit them only after release of 2.0.9 to do trunk and 2.* on the same day. Then I'll do these parameters too. Please remind me if I forget. was (Author: tilman): {quote} Tilman Hausherr Would you mind reviewing the warning "Introduce a new variable instead of reusing the parameter "subsampling" for lines 234, 346, 421 in SampledImageReader? Sonar doesn't like reassigning method parameter values. {quote} Will do but after I've done the two other pending changes to avoid the patches getting invalid and me having extra work. I will commit them only after release of 2.0.9 to do trunk and 2.* on the same day. Then I'll do these parameters too. Please remind me if I forget. > Improve code quality (3) > ------------------------ > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task > Affects Versions: 2.0.8 > Reporter: Tilman Hausherr > Priority: Major > Attachments: pdfbox-screenshot-bad.png, pdfbox-screenshot-good.png > > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org