[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350678#comment-16350678
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 3/22/18 6:34 PM:
------------------------------------------------------------------

Thanks... I tested with many PDFs, there are a lot of differences, some are 
rendered incorrectly (e.g. [^gs-bugzilla690477.pdf])... maybe start with 
 
[http://www.eci.org/_media/downloads/altona_test_suite/eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf]
 there is an exception (IOOB) on page 17. Of course I can't say for sure if it 
is a bug in your change, or if your change uncovered bugs that have been there 
already.

It might also be possible that I messed up something while inserting your code. 
If possible, try attaching real diff / patch files, this avoids any human error.


was (Author: tilman):
Thanks... I tested with many PDFs, there are a lot of differences, some are 
rendered incorrectly (e.g. [^gs-bugzilla690477.pdf])... maybe start with 
 
[http://www.eci.org/_media/downloads/altona_test_suite/eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf]
 there is an exception (IOOB) on one of the last pages. Of course I can't say 
for sure if it is a bug in your change, or if your change uncovered bugs that 
have been there already.

It might also be possible that I messed up something while inserting your code. 
If possible, try attaching real diff / patch files, this avoids any human error.

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> ----------------------------------------------------------------------------
>
>                 Key: PDFBOX-4095
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4095
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Rendering
>    Affects Versions: 2.0.8
>            Reporter: savan patel
>            Priority: Major
>         Attachments: BlendComposite.java.patch, BlendMode.java.patch, 
> COSName.java.patch, blendmodes.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla697433-1.pdf
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to