[ https://issues.apache.org/jira/browse/PDFBOX-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438401#comment-16438401 ]
Palash Ray commented on PDFBOX-4189: ------------------------------------ * +{color:#333333}What is the story of having different data for jdk7 and jdk8{color}+ Out of 323 entries for the GSUB table for the Bengali-Lohit.ttf font, I am getting a single entry which differs for jdk1.7 and 1.8. Thats the reason I had to create the 2 files. I am still investigating this, so maybe, I will come up with a better solution when I get to the bottom of this * +I'd also need to know where this file came from, or whether you created it yourself from other data+ Those .txt files are simple reference data used for testing the correctness of the GSUB tables. I have created them by putting some logic, transforming unicode characters into base-10 numbers. * +BengaliPdfGenerationHelloWorld should be integrated into the EmbeddedFonts.java example+ Will do * +why a log4j2.xml ? We don't use log4j2 except in preflight where log4j is used in Tests+ Agreed, I will remove the log4j2.xml * +You disabled subsetting+ I don't understand that yet. Please bear with me, I will make it work even with that. Let me take a look. * +The move of GlyphsubstitutionTable+ I can move it back if it simplifies things. Should I? * +There is a lot of logging done+ Will do * +Loosening scope restrictions is a bit of a no-no+ Agreed. I did this as a part of the move of GlyphsubstitutionTable, if I undo the move, this will be taken care of. * +Public methods should have a javadoc+ Will do Thanks, Palash. > Enable rendering of Indian languages, by reading and utilizing the GSUB table > ----------------------------------------------------------------------------- > > Key: PDFBOX-4189 > URL: https://issues.apache.org/jira/browse/PDFBOX-4189 > Project: PDFBox > Issue Type: New Feature > Components: FontBox, PDModel > Reporter: Palash Ray > Priority: Major > Attachments: Bengali-text-after.pdf, Bengali-text-before.pdf > > Original Estimate: 336h > Remaining Estimate: 336h > > Implemented proper rendering of Indian languages, which need extensive Glyph > substitution. The GSUB table has been read and used effectively to replace > some compound words with their respective Glyphs. All tests are passing. I > have tested this for the Bengali font. Please review these changes and let me > know if it makes sense to incorporate these. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org