[ https://issues.apache.org/jira/browse/PDFBOX-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456467#comment-16456467 ]
Tilman Hausherr commented on PDFBOX-4189: ----------------------------------------- SonarQube complains about GsubData https://builds.apache.org/analysis/issues/search#issues=AWL626kbQm2yumf9gGSR If you click on "..." there's an explanation that cites [Joshua Bloch|https://en.wikipedia.org/wiki/Joshua_Bloch]. I assume the SonarQube complaint is really about NO_DATA_FOUND. I wonder what this is for - all its methods fail. Why not just return null instead of NO_DATA_FOUND? You're checking for == NO_DATA_FOUND so IMHO this isn't much different than checking for null. I'm aware that "not using null" is usually a good practice. Anyway, think about it :-) > Enable PDF creation with Indian languages, by reading and utilizing the GSUB > table > ---------------------------------------------------------------------------------- > > Key: PDFBOX-4189 > URL: https://issues.apache.org/jira/browse/PDFBOX-4189 > Project: PDFBox > Issue Type: New Feature > Components: FontBox, PDModel > Reporter: Palash Ray > Priority: Major > Attachments: Bengali-text-after.pdf, Bengali-text-before.pdf, > BengaliPdfGenerationHelloWorld.java, bengali-example.pdf, > bengali-example2.pdf, committed.patch, screenshot.png > > Original Estimate: 336h > Remaining Estimate: 336h > > Implemented proper rendering of Indian languages, which need extensive Glyph > substitution. The GSUB table has been read and used effectively to replace > some compound words with their respective Glyphs. All tests are passing. I > have tested this for the Bengali font. Please review these changes and let me > know if it makes sense to incorporate these. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org