[
https://issues.apache.org/jira/browse/PDFBOX-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469705#comment-16469705
]
John Hewson commented on PDFBOX-4068:
-------------------------------------
Hi guys, I've been taking a look at the code from PDFBOX-4189 and there are a
few problems related to this change which I've uncovered. There's some
copy-paste duplicated code in both PDAbstractContentStream and
PDPageContentStream which has led to PDPageContentStream having its own local
copies of the font stack (!). Also as PDPageContentStream was copied to create
PDAbstractContentStream but made non-final, all the methods now need to be
final. Finally, unless we want users to subclass PDAbstractContentStream (and
given that PDPageContentStream was previously final, I presume we don't) then
all the PDAbstractContentStream subclasses need to be in the same package.
> Create ContentStream for XObject forms and tiling patterns
> ----------------------------------------------------------
>
> Key: PDFBOX-4068
> URL: https://issues.apache.org/jira/browse/PDFBOX-4068
> Project: PDFBox
> Issue Type: Task
> Components: PDModel
> Reporter: Tilman Hausherr
> Priority: Major
>
> We have a {{PDAppearanceContentStream}} for appearances but nothing for
> XObject forms and tiling patterns.
> What we need should extend {{PDAbstractContentStream}} and should have a
> constructor like
> {code:java}
> public PDFormContentStream(PDFormXObject form) throws IOException
> {code}
> Alternatively, why not replace {{PDAppearanceContentStream}} ? Its parameter
> {{PDAppearanceStream}} is extended from {{PDFormXObject}} so we could just
> use the base class.
> We need this both for 2.0 and 3.* - we have users who have a really hard time
> fiddling with low level operators instead of using the methods.
> In 2.0 we could replace the parameter of {{PDPageContentStream}} that is
> currently {{PDAppearanceStream}}. This would be a non breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
