Github user hennejg commented on a diff in the pull request:

    https://github.com/apache/pdfbox-jbig2/pull/1#discussion_r209574636
  
    --- Diff: pom.xml ---
    @@ -220,14 +220,19 @@
           <url>https://git-wip-us.apache.org/repos/asf?p=pdfbox-jbig2.git</url>
           <tag>HEAD</tag>
       </scm>
    -   
    +
         <dependencies>
    -   <dependency>
    -           <groupId>junit</groupId>
    -           <artifactId>junit</artifactId>
    -           <version>4.10</version>
    -           <scope>test</scope>
    -   </dependency>
    +        <dependency>
    +            <groupId>junit</groupId>
    +            <artifactId>junit</artifactId>
    +            <version>4.10</version>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    --- End diff --
    
    I am not so sure that it is fine to just add a dependency on Guava here. 
Why nox fix the existing Implementation by adding weak keys? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to