[ 
https://issues.apache.org/jira/browse/PDFBOX-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596286#comment-16596286
 ] 

Adrian Sandor commented on PDFBOX-4294:
---------------------------------------

In the meantime I renamed MyOverlay to OverlayEngine, made a bunch of 
improvements, and refactored the Overlay class (based on revision 1839173 in 
branch 2.0) to make use of it. This will let people use Overlay exactly the 
same way as before, and give them an additional option to use the more flexible 
OverlayEngine if they want to. Feel free to add my code to pdfbox and make any 
changes you deem necessary.

> Scratch file already closed when redoing overlay
> ------------------------------------------------
>
>                 Key: PDFBOX-4294
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4294
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.0.11
>            Reporter: Adrian Sandor
>            Priority: Major
>         Attachments: MyOverlay.java, overlay.zip
>
>
> Here's some sample code to reproduce the problem:
>  
> {code:java}
> final String path = "orig.pdf";
> final String stampPath = "stamp.pdf";
> final PDDocument doc = PDDocument.load(new File(path));
> final Overlay o = new Overlay();
> o.setInputPDF(doc);
> o.setOverlayPosition(Position.FOREGROUND);
> final HashMap<Integer, String> m = new HashMap<>();
> m.put(0, stampPath);
> PDDocument res = o.overlay(m);
> res.close();
> res = o.overlay(m);
> {code}
> Basically I'm doing an overlay, closing the resulting document, then doing it 
> again (normally I would make some changes first, but I didn't include that 
> for the sake of brevity).
> The last line throws java.io.IOException: Scratch file already closed
> If I remove "res.close()" then the code works, but if I do the overlay 
> multiple times, I get warnings like: org.apache.pdfbox.cos.COSDocument - 
> Warning: You did not close a PDF Document
> which suggests that I should actually close the document when I'm done with 
> it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to