[ 
https://issues.apache.org/jira/browse/PDFBOX-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756939#comment-16756939
 ] 

Andreas Lehmkühler commented on PDFBOX-4446:
--------------------------------------------

I don't see any reason not to add that patch, as long as:
- it's active in lenient mode only
- a null value isn't added
- maybe some debug log should be added to identify such cases

[~tilman] and [~mkl] already discussed that points.

As always, this change might fix pdfs like Dereks, but in other cases it will 
just exchange the avoided exception with another one.

> Tolerate some incorrect Xref in PDF file
> ----------------------------------------
>
>                 Key: PDFBOX-4446
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4446
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>    Affects Versions: 2.0.14, 3.0.0 PDFBox
>            Reporter: Derek Liu
>            Priority: Major
>             Fix For: 2.0.14, 3.0.0 PDFBox
>
>         Attachments: Reproduce_Step.png
>
>
> Some PDF file may not have correct Xref, and we should tolerate them. Or just 
> log an error but not raise exception.
> {code}
>  pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java | 3 +++
>  1 file changed, 3 insertions(+)
> diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java 
> b/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
> index 8ca955ed2..b2b28b258 100644
> --- a/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
> +++ b/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
> @@ -721,6 +721,9 @@ public class COSParser extends BaseParser
>                                      }
>                                  }
>  
> +                                if( fileOffset == null ) {
> +                                  continue;
> +                                }
>                                  List<COSObject> stmObjects = 
> objToBeParsed.get(fileOffset);
>                                  if (stmObjects == null)
>                                  {
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to