[ https://issues.apache.org/jira/browse/PDFBOX-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010622#comment-17010622 ]
Maruan Sahyoun edited comment on PDFBOX-4723 at 1/8/20 12:08 PM: ----------------------------------------------------------------- [~mkl] thanks for pointing it out. Now this gets more and more difficult :-) A "standard" java Map like HashMap is equal if it has the same content. For SmallMap that's not true. IMHO this is against the users expectation. So I will look into implementaing equals and hashCode for SmallMap too. was (Author: msahyoun): [~mkl] thanks for pointing it out. Now this gets more and more difficult :-) > Add equals() and hashCode() to PDAnnotation and COS objects > ----------------------------------------------------------- > > Key: PDFBOX-4723 > URL: https://issues.apache.org/jira/browse/PDFBOX-4723 > Project: PDFBox > Issue Type: Sub-task > Components: PDModel > Affects Versions: 2.0.18 > Reporter: Maruan Sahyoun > Assignee: Maruan Sahyoun > Priority: Major > Fix For: 2.0.19, 3.0.0 PDFBox > > > In order to proper support removeAll/retainAll for COSArrayList we need to > detect if entries are in fact duplicates of others. This currently fails as > even though one might add the same instance of an annotation object multiple > times to setAnnotations getting the annotations will have individual > instances. See the discussion at PDFBOX-4669. > In order to proper support removal we need to be able to detect equality > where an object is equal if the underlying COSDictionary has the same entries. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org