[ https://issues.apache.org/jira/browse/PDFBOX-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133235#comment-17133235 ]
Alfred edited comment on PDFBOX-4877 at 6/11/20, 12:54 PM: ----------------------------------------------------------- I know PDFs are not well formed. My point was that an exception will not help, on the contrary, parsing will fail, would it not? If it was a sensible default or any other idea in the direction of accepting the malformed PDF and displaying the closest image we can get, I would have understood. But this code says "if infinite, then throw", so I am not sure how that helps ... was (Author: faltiska): I know PDFs are not well formed. My point was that an exception will not help, on the contrary, parsing will fail, would it not? If it was a sensible default or any other idea in the direction of accept the malformed PDF and displaying the closest image we can get, I would have understood. But this code says "if infinite, then throw", so I am not sure how that helps ... > Matrix class performance improvements > ------------------------------------- > > Key: PDFBOX-4877 > URL: https://issues.apache.org/jira/browse/PDFBOX-4877 > Project: PDFBox > Issue Type: Improvement > Components: Parsing, Text extraction > Affects Versions: 2.0.20, 3.0.0 PDFBox > Reporter: Alfred > Assignee: Andreas Lehmkühler > Priority: Major > Labels: Optimization > Attachments: PDFBOX-4877.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > I am testing text extraction from PDF and profiling the execution. > I found that the third major time consumer is with matrix multiplicaitons. > The Matrix class spends large amounts of time copying results to new > instances. > Also, the if statements are slowing down execution as they kill performance > in modern CPUs. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org