[ https://issues.apache.org/jira/browse/PDFBOX-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160435#comment-17160435 ]
ASF subversion and git services commented on PDFBOX-4895: --------------------------------------------------------- Commit 1880029 from Tilman Hausherr in branch 'pdfbox/branches/issue45' [ https://svn.apache.org/r1880029 ] PDFBOX-4895: add test for numbers too big for a long but small enough to fit into a float, by Alfred Faltiska > Faster COSNumber > ---------------- > > Key: PDFBOX-4895 > URL: https://issues.apache.org/jira/browse/PDFBOX-4895 > Project: PDFBox > Issue Type: Improvement > Affects Versions: 2.0.20, 3.0.0 PDFBox > Reporter: Alfred > Assignee: Tilman Hausherr > Priority: Trivial > Labels: Optimization > Fix For: 2.0.21, 3.0.0 PDFBox > > Attachments: PDFBOX-4895-b.patch, PDFBOX-4895.patch > > > A small improvement can be made to COSNumber when checking if it's float. > Current version uses indexOf twice, to check for '.' or 'e'. > We can do that in one scan. > > Each call will scan through the entire string. > We only have to scan until we find the chars, and stop if found. > > I found while profiling the code that the method gets called a lot, so the > improvement makes a a bit of a difference. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org