[ 
https://issues.apache.org/jira/browse/PDFBOX-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163436#comment-17163436
 ] 

Alfred edited comment on PDFBOX-4909 at 7/23/20, 11:14 AM:
-----------------------------------------------------------

Sure, the code can stay there and be an overridable method.

But the result of the calculation is a number that has the same life span as 
the font object.

We could have a field called correctedHeight in the font.

Or we could simply use a map to store correctedHeight per font identifier ?

 


was (Author: faltiska):
Sure, the code can stay there and be an overridable method.

But the result of the calculation is a number that has the same life span as 
the font object.

We could have a field called correctedHeight.

Or we could simply use a map to store correctedHeight per font identifier ?

 

> Don't calculate font height for every glyph
> -------------------------------------------
>
>                 Key: PDFBOX-4909
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4909
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Text extraction
>    Affects Versions: 2.0.0, 3.0.0 PDFBox
>            Reporter: Alfred
>            Assignee: Tilman Hausherr
>            Priority: Major
>              Labels: Optimization
>             Fix For: 2.0.21, 3.0.0 PDFBox
>
>         Attachments: PDFBOX-4909.patch
>
>
> LegacyPDFStreamEngine computes font height for every glyph and the 
> computation is rather heavy, to work around all known problems.
> Instead of computing for every glyph, we can recompute only when the font 
> changes. The SetFontAndSize operator will be invoked when the font changes so 
> we can use that to compute and store the height to have it ready when needed 
> in showGlyph.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to