[
https://issues.apache.org/jira/browse/PDFBOX-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191088#comment-17191088
]
Andreas Lehmkühler edited comment on PDFBOX-4723 at 9/5/20, 4:42 PM:
---------------------------------------------------------------------
Thanks to all for the valuable discussion and the detailed input. How about
folowing an another approach.
This is all about COSArrayList and I had a look at the code. It looks like
there are several cases where we don't need to use a COSArrayList but a simple
ArrayList instead. Let us eliminate those cases and see where it leads. I've
create PDFBOX-4954 to do so.
was (Author: lehmi):
Thanks to all for the valuable discussion and the detailed input. How about
folowing an another approach.
This is all about COSArrayList and I had a look at the code. It looks like
there are several cases where we don't need to use a COSArrayList but a simple
ArrayList instead. Let us eliminate those cases and see where it leads. I'm
going to create a new ticket to do so.
> Add equals() and hashCode() to PDAnnotation and COS objects
> -----------------------------------------------------------
>
> Key: PDFBOX-4723
> URL: https://issues.apache.org/jira/browse/PDFBOX-4723
> Project: PDFBox
> Issue Type: Sub-task
> Components: PDModel
> Affects Versions: 2.0.18
> Reporter: Maruan Sahyoun
> Assignee: Maruan Sahyoun
> Priority: Major
> Fix For: 3.0.0 PDFBox
>
> Attachments: bird_burst.heic.pdf, image-2020-09-02-13-52-21-370.png,
> image-2020-09-02-13-53-02-622.png, image-2020-09-02-13-54-31-630.png,
> screenshot-1.png
>
>
> In order to proper support removeAll/retainAll for COSArrayList we need to
> detect if entries are in fact duplicates of others. This currently fails as
> even though one might add the same instance of an annotation object multiple
> times to setAnnotations getting the annotations will have individual
> instances. See the discussion at PDFBOX-4669.
> In order to proper support removal we need to be able to detect equality
> where an object is equal if the underlying COSDictionary has the same entries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
