[ 
https://issues.apache.org/jira/browse/PDFBOX-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305486#comment-17305486
 ] 

Andreas Lehmkühler commented on PDFBOX-5136:
--------------------------------------------

I've removed COSDocument#finalize from the trunk and am not sure if it can be 
done for the 2.0 branch as well. The whole IO-stuff is different and it is 
maybe a showstopper?

> Remove COSDocument#finalize
> ---------------------------
>
>                 Key: PDFBOX-5136
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5136
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing, PDModel
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>             Fix For: 3.0.0 PDFBox
>
>
> PDDocument implements the Closeable interface a closes the underlying 
> instance of COSDocument once it is closed itself, so that there is no need to 
> use the finalize method to perform a sanity check about not closed resources. 
> Furthermore it is a bad idea to overwrite finalize for different good 
> reasons. See PDFBOX-4202 for some additional information



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to