[GitHub] [pdfbox] THausherr commented on pull request #111: Faster PDImageXObject.applyMask

[GitBox]

THausherr commented on pull request #111:
URL: https://github.com/apache/pdfbox/pull/111#issuecomment-808905144


   Thanks; there one difference in rendering here (page 14):
   
[PDFBOX-1359.pdf](https://github.com/apache/pdfbox/files/6217477/PDFBOX-1359.pdf)
   
   Original:
   ![PDFBOX-1359 
pdf-14](https://user-images.githubusercontent.com/6665575/112755799-992a5000-8fe2-11eb-97cb-16fcafc6f64c.png)
   
   New:
   ![PDFBOX-1359 
pdf-14](https://user-images.githubusercontent.com/6665575/112755927-279ed180-8fe3-11eb-976d-dc1d3b9585c3.png)
   
   Difference:
   ![PDFBOX-1359 pdf-14 
png-diff](https://user-images.githubusercontent.com/6665575/112755931-2d94b280-8fe3-11eb-8c11-d04878f8866f.png)
   
   
   The difference can't been seen with a human eye so they're minor and I often 
have such differences myself when making changes. However here I don't 
understand what happened, there should only be a difference of 1 due to 
rounding. The differences algorithm (TestPDFToImages.diffImages()) only 
complains when there is a difference of 3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org