valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-907833215
Hi, @THausherr! My two observations. 1 Is it not too math to enlarge ScratchFileBuffer.pageIndexes array length twice (ScratchFileBuffer.addPage)? 2 PDVisibleSigBuilder.createTemplate. If this method will be called twice then previous template (PDDocument) not be closed. You able to store link to that template in a PDVisibleSigBuilder. If this link will be same as template field then it will be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
