[
https://issues.apache.org/jira/browse/PDFBOX-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447057#comment-17447057
]
Maruan Sahyoun commented on PDFBOX-5286:
----------------------------------------
[~lehmi] again looks better. Not only the runtime number went down but also the
error margin.
{noformat}
Benchmark Mode Cnt Score Error
Units
LoadAndSave.saveNoCompressionLargeFile ss 5 4149,505 ± 370,951
ms/op
{noformat}
Looking at the profiling data {{java.util.ArrayDeque.contains ()}} still
accounts for {{1.842 ms}} That's mainly coming from COSArray within a
COSDictionary. I'm currently working on adding the benchmarks as a new module.
Will add it as a patch to a new ticket for review before doing a commit so
there is a chance to review it before it lands in source control
> Runtime degredation in RC1 and alpha2
> -------------------------------------
>
> Key: PDFBOX-5286
> URL: https://issues.apache.org/jira/browse/PDFBOX-5286
> Project: PDFBox
> Issue Type: Bug
> Components: Parsing
> Affects Versions: 3.0.0 PDFBox
> Reporter: Maruan Sahyoun
> Priority: Critical
>
> working/reviewing PDFBOX-5068 and PDFBOX-5263 I've experiencing runtime
> issues for both 3.0.0-RC1 and 3.0.0-alpha2 when loading and saving a large PDF
> https://crossasia-books.ub.uni-heidelberg.de/xasia/reader/download/506/506-42-86246-2-10-20190822.pdf
>
> ||version||runtime in millis||
> |2.0.24 |2076|
> |3.0.0-RC1 |219472|
> |3.0.0-alpha2 |282284|
> Basic test:
> {code:java}
> long start = System.currentTimeMillis();
> PDDocument pdf = Loader.loadPDF(new File("506-42-86246-2-10-20190822.pdf"));
> pdf.save(new NullOutputStream());
> pdf.close();
> long end = System.currentTimeMillis();
> System.out.println("Elapsed Time in milliseconds: "+ (end-start));
> {code}
> with NullOuputStream
> {code:java}
> package org.apache.pdfbox;
> import java.io.IOException;
> import java.io.OutputStream;
> public class NullOutputStream extends OutputStream {
> @Override
> public void write(byte[] b) throws IOException {
> // don't write anything
> }
> @Override
> public void write(byte[] b, int off, int len) throws IOException {
> // don't write anything
> }
> @Override
> public void write(int b) throws IOException {
> // don't write anything
> }
> }
> {code}
> I've also running tests using JMH - they support these numbers. The
> difference in numbers for RC1/alpha2 are within a regular variation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
