valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1121512722
> > > > Hi, @THausherr ! 1 The method PDFPrintable.print has affine transform clonning (260). Is this operation really needed or is it old code? 2 the classes from org.apache.pdfbox.pdmodel.font.encoding packege have public constructors but they have field with comment "Singleton instance of this class". The same for a packege org.apache.fontbox.encoding. 3 The packages org.apache.fontbox.encoding and org.apache.pdfbox.pdmodel.font.encoding contain the MacRomanEncoding class. The encoding tables of these classes are not much different. Perhaps they were separated due to different encoding tables. > > > > > > > > > Thanks, I made two of the three proposed changes. I prefer not to tough the third one due to the difference. > > > > > > Hi, @THausherr! About PDFPrintable, line 260. I thought you would remove the AffineTransform instance from the code (remove those lines). I can't understand the whole logic of this code, but why do you need to set a transformation clone (check the graphics2D.getTransform java doc) on line 269? > > I have removed the clone, maybe you have an older version of the code. I kept the rest of the code. The purpose of this part is to restore the original transform when painting the border. Thank you for respond. I understood. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
