[
https://issues.apache.org/jira/browse/PDFBOX-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794265#comment-17794265
]
Tilman Hausherr edited comment on PDFBOX-5729 at 12/7/23 3:28 PM:
------------------------------------------------------------------
[~javauser] Thank you for your code. Please tell wether the output is what
you'd expect.
For Devanagari my impression is that NotoSansDevanagari fails partially, lohit,
siddhanta and tiro are fine, mangal almost (the third glyph is missing the top
horizontal line).
For Gujarati my impression is that none is really good, the big glyph in the
third word is always at the wrong position. It also looks better on the
website, the huge arc in "શિ" isn't broken.
The missing parts may have three causes:
- errors in the fonts (probably not)
- errors in the existing code (could be detected through debugging by looking
at the tables in DTL OTMaster or with another tool)
- missing implementation of tables of type 5 or 6.
More TODOs:
- test code like GsubWorkerForBengaliTest.java => here I'd need your help with
at least some representative input data where you'd expect a substitution.
Ideally with a font that has the apache or the SIL license.
- test code like TestFontEmbedding.testBengali()
was (Author: tilman):
[~javauser] Thank you for your code. Please tell wether the output is what
you'd expect.
For Devanagari my impression is that NotoSansDevanagari fails partially,
siddhanta and tiro are fine, mangal almost (the third glyph is missing the top
horizontal line).
For Gujarati my impression is that none is really good, the big glyph in the
third word is always at the wrong position. It also looks better on the
website, the huge arc in "શિ" isn't broken.
The missing parts may have three causes:
- errors in the fonts (probably not)
- errors in the existing code (could be detected through debugging by looking
at the tables in DTL OTMaster or with another tool)
- missing implementation of tables of type 5 or 6.
More TODOs:
- test code like GsubWorkerForBengaliTest.java => here I'd need your help with
at least some representative input data where you'd expect a substitution.
Ideally with a font that has the apache or the SIL license.
- test code like TestFontEmbedding.testBengali()
> GsubWorkerForDevanagari and GsubWorkerForGujarati created
> ---------------------------------------------------------
>
> Key: PDFBOX-5729
> URL: https://issues.apache.org/jira/browse/PDFBOX-5729
> Project: PDFBox
> Issue Type: Improvement
> Components: FontBox
> Affects Versions: 3.0.0 PDFBox
> Reporter: JAVA USER
> Priority: Trivial
> Labels: GsubWorkerForDevanagari, GsubWorkerForGujarati
> Attachments: GsubWorkerForDevanagari.java,
> GsubWorkerForGujarati.java, NotoSansDevanagari-Regular.ttf, Screenshot from
> 2023-12-07 20-46-25.png, TiroDevanagariHindi-Regular.ttf,
> devanagari-example-TiroDevanagariHindi.pdf, devanagari-example-bad.pdf,
> devanagari-example-notosans.pdf, devanagari-example-siddhanta.pdf,
> image-2023-12-07-09-54-31-449.png, image-2023-12-07-10-18-33-457.png,
> image-2023-12-07-10-33-37-499.png, image-2023-12-07-14-39-24-187.png,
> image-2023-12-07-16-27-22-510.png, screenshot-1.png, screenshot-2.png,
> screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png
>
>
> Created Gsub workers for Devanagari and Gujarati languages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
