[ 
https://issues.apache.org/jira/browse/PDFBOX-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795094#comment-17795094
 ] 

JAVA USER edited comment on PDFBOX-5729 at 12/10/23 6:05 PM:
-------------------------------------------------------------

1. abvs is failing because we're performing adjustRephPosition function, hence, 
the components required for abvs are not in correct sequence. Since there is no 
unicode for reph glyph, I'm unable to adjust it after the abvs has converted 
those components to reph glyph, and if it is not readjusted, then it applies 
itself to wrong consonant. I think GPOS will be responsible for its reposition.

2. I don't know why blws failed; as you can see in [^output.pdf] glyph 663 (हृ) 
is correctly exported from 362 (ह) and 372 (  ृ ).

3. cjct failed on one glyph (द्ध्र्य) because there are two virama glyph 
components (द‌्+ध‌्+र्य). I don't know why but whenever there are two 
consecutive virama glyphs in a word (  ् ) the feature responsible won't work. 
Otherwise cjct is working as expected.

4. same with psts; we're adjusting reph glyph that's why psts isn't able to 
find correct sequence of glyphs to apply properly on glyphs 326,578,661 (र्की) 
and 368, 326 307 (किं) needs GPOS.

5. rkrf is most likely failing because it's borrowing glyphs from vatu. But you 
can see in [^rkrf.pdf] the output is what we desired (क्रब्रप्रह्र).

I'll submit test files for Gujarati tomorrow. Please use latest version of 
Lohit-Gujarati 
https://releases.pagure.org/lohit/lohit-gujarati-ttf-2.92.4.tar.gz.


was (Author: javauser):
1. abvs is failing because we're performing adjustRephPosition function, hence, 
the components required for abvs are not in correct sequence. Since there is no 
unicode for reph glyph, I'm unable to adjust it after the abvs has converted 
those components to reph glyph, and if it is not readjusted, then it applies 
itself to wrong consonant. I think GPOS will be responsible for its reposition.

2. I don't know why blws failed; as you can see in [^output.pdf] glyph 663 (हृ) 
is correctly exported from 362 (ह) and 372 (  ृ ).

3. cjct failed on one glyph (द्ध्र्य) because there are two virama glyph 
components (द‌्+ध‌्+र्य). I don't know why but whenever there are two 
consecutive virama glyphs in a word (  ् ) the feature responsible won't work. 
Otherwise cjct is working as expected.

4. same with psts; we're adjusting reph glyph that's why psts isn't able to 
find correct sequence of glyphs to apply properly on glyphs 326,578,661 (र्की) 
and 368, 326 307 (किं) needs GPOS.

5. rkrf is most likely failing because it's borrowing glyphs from vatu. But you 
can see in [^rkrf.pdf] the output is what we desired (क्रब्रप्रह्र).

> GsubWorkerForDevanagari and GsubWorkerForGujarati created
> ---------------------------------------------------------
>
>                 Key: PDFBOX-5729
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5729
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: FontBox
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: JAVA USER
>            Priority: Trivial
>              Labels: GsubWorkerForDevanagari, GsubWorkerForGujarati
>         Attachments: GsubWorkerForDevanagari-1.java, 
> GsubWorkerForDevanagari-2.java, GsubWorkerForDevanagari.java, 
> GsubWorkerForDevanagariTest.java, GsubWorkerForGujarati-1.java, 
> GsubWorkerForGujarati-2.java, GsubWorkerForGujarati.java, 
> NotoSansDevanagari-Regular.ttf, Screenshot from 2023-12-07 20-46-25.png, 
> Screenshot from 2023-12-10 16-54-09.png, Screenshot from 2023-12-10 
> 16-54-30.png, TestFontEmbedding.java, TiroDevanagariHindi-Regular.ttf, 
> devanagari-example-TiroDevanagariHindi.pdf, devanagari-example-bad.pdf, 
> devanagari-example-notosans.pdf, devanagari-example-siddhanta.pdf, 
> image-2023-12-07-09-54-31-449.png, image-2023-12-07-10-18-33-457.png, 
> image-2023-12-07-10-33-37-499.png, image-2023-12-07-14-39-24-187.png, 
> image-2023-12-07-16-27-22-510.png, output-1.pdf, output.pdf, rkrf.pdf, 
> screenshot-1.png, screenshot-2.png, screenshot-3.png, screenshot-4.png, 
> screenshot-5.png, screenshot-6.png, screenshot-7.png, screenshot-8.png
>
>
> Created Gsub workers for Devanagari and Gujarati languages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to