DvonHolten commented on code in PR #186: URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498751356
########## pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java: ########## @@ -29,6 +29,7 @@ public class MacRomanEncoding extends Encoding /** * Table of octal character codes and their corresponding names. */ + @SuppressWarnings("OctalInteger") Review Comment: there are other SuppressWarnings (like "squid:S106" or "SpellCheckingInspection"). There are just a few warnings defined in Java, so that annotation mostly adresses 'other tools'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org