[ 
https://issues.apache.org/jira/browse/PDFBOX-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841033#comment-17841033
 ] 

Tilman Hausherr edited comment on PDFBOX-5808 at 4/26/24 8:27 AM:
------------------------------------------------------------------

I'm back to my earlier thought, I want to understand that collision thing 
first. The problem is that the tests have completely changed (e.g. the calibri 
tests). Ideally, the tests should only slightly change, or have new test cases 
added. Here the new font should be added so we can see what improved (we can 
still remove the calibri tests later).


was (Author: tilman):
I'm back to my earlier thought, I want to understand that collision thing 
first. The problem is that the tests have completely changed (e.g. the calibri 
tests). Ideally, the tests should only slightly change, or have new test cases 
added. Here the new font should be added so we can see what improved (we can 
still remove the calibri tests later). And why is the Bangla test gone (and 
others)? And "attention" is not part of the tests.

Can you explain a specific failure that would happen with the foglihtenno07 
font now, if the code isn't changed?

> Add support for GSUB Lookup Type 3
> ----------------------------------
>
>                 Key: PDFBOX-5808
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5808
>             Project: PDFBox
>          Issue Type: New Feature
>          Components: FontBox
>    Affects Versions: 3.0.2 PDFBox
>            Reporter: Fabrice Calafat
>            Priority: Major
>
> Add support for the lookup type 3, Alternate Substitution when handling GSUB:
> [https://learn.microsoft.com/en-us/typography/opentype/spec/gsub#AS]
> The first available substitution glyph can be used (as done in other 
> libraries)
>  
> Also, the current implementation of CompoundCharacterTokenizer doesn't 
> account for collision in ligatures
> For example, if a font supports ligatures for _att_ and {_}en{_}, the current 
> implementation will not tokenize properly for the word _attention._ This is 
> because the regex implementation doesn't allow for a proper split
>  
> I'll open a proposed implementation for the above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to