valerybokov opened a new pull request, #274: URL: https://github.com/apache/pdfbox/pull/274
1 I think we should close this stream especially if we got it by this way (CMapParser.getExternalCMap): InputStream is = getClass().getResourceAsStream(name); 2 Possible optimisation for future: We often use ByteArrayInputStream as parameter of the constructor RandomAccessReadBuffer(InputStream). The ByteArrayInputStream is the array wrapper. There is no need to create List<ByteBuffer> for this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
