lehmi commented on code in PR #287:
URL: https://github.com/apache/pdfbox/pull/287#discussion_r2423782244
##########
io/src/main/java/org/apache/pdfbox/io/RandomAccessReadMemoryMappedFile.java:
##########
@@ -110,6 +110,7 @@ public void close() throws IOException
if (fileChannel != null)
{
fileChannel.close();
+ fileChannel = null;
Review Comment:
OK, that is a reasonable point. IMHO the close operation should be moved to
the if clause of the mappedByteBuffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
