xzel23 commented on PR #316: URL: https://github.com/apache/pdfbox/pull/316#issuecomment-3506776452
I have to say that IMHO the new code is much simpler and easier to read and maintain and would suggest simply accepting this in the Sonar web interface so that it won't show up any more in future runs of the analyzer. But it is a valid point and it's up to the project to decide whether marking issues as accepted in Sonar is an acceptable solution. Another solution would be to simply define a new variable and assign it in the body of the if-statement. I think that would still make the code easier to read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
