[ 
https://issues.apache.org/jira/browse/PDFBOX-6154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18055422#comment-18055422
 ] 

Tilman Hausherr commented on PDFBOX-6154:
-----------------------------------------

shiftAndFill() has a bug, it divides negative numbers by 256 twice instead of 
once. And it isn't needed at all, the ">>" of java does the job that ">> A" 
does according to the specification
{quote}If V1 and V2 are two integers, then V1 >> A V2 is the value obtained by 
shifting the value of V1 rightward by V2 bits, filling the leftmost V2 bits of 
the new value with 0 if V1 is non-negative and 1 if V1 is negative.
{quote}

> HENABLESKIP isn't supported
> ---------------------------
>
>                 Key: PDFBOX-6154
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-6154
>             Project: PDFBox
>          Issue Type: Sub-task
>          Components: JBIG2
>    Affects Versions: 3.0.4 JBIG2
>            Reporter: Tilman Hausherr
>            Priority: Minor
>         Attachments: 1769433802492.png
>
>
> This is described in "6.6.5.1 Computing HSKIP". I managed to implement the 
> bitmap but not yet to do anything with it. Until this is fully implemented we 
> should throw an IOException instead of letting an IOOB happen.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to