Smityz commented on a change in pull request #624:
URL: https://github.com/apache/incubator-pegasus/pull/624#discussion_r508320346
##########
File path: src/server/hotkey_collector.h
##########
@@ -75,28 +81,48 @@ class hotkey_collector : public
dsn::replication::replica_base
void analyse_data();
void handle_rpc(const dsn::replication::detect_hotkey_request &req,
/*out*/ dsn::replication::detect_hotkey_response &resp);
+ static int get_bucket_id(dsn::string_view data);
Review comment:
it will be used in `hotkey_coarse_data_collector` and
`hotkey_fine_data_collector`
I think it is a public method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
