levy5307 commented on a change in pull request #631:
URL: https://github.com/apache/incubator-pegasus/pull/631#discussion_r517088516
##########
File path: src/server/hotkey_collector.cpp
##########
@@ -21,21 +21,31 @@
#include <dsn/utility/smart_pointers.h>
#include <dsn/utility/flags.h>
#include <boost/functional/hash.hpp>
-#include "base/pegasus_key_schema.h"
#include <dsn/dist/fmt_logging.h>
#include <dsn/utility/flags.h>
+#include <dsn/tool-api/task.h>
+#include <dsn/dist/replication/replication.codes.h>
+#include "base/pegasus_key_schema.h"
namespace pegasus {
namespace server {
DSN_DEFINE_int32("pegasus.server",
coarse_data_variance_threshold,
3,
- "the threshold of variance calculate to find the outliers");
+ "the threshold of variance calculate to find the outliers in
coarse analyse");
DSN_DEFINE_validator(coarse_data_variance_threshold,
[](int32_t threshold) -> bool { return (threshold >= 0);
});
+DSN_DEFINE_int32("pegasus.server",
+ fine_data_variance_threshold,
+ 3,
+ "the threshold of variance calculate to find the outliers in
fine analyse");
+
+DSN_DEFINE_validator(fine_data_variance_threshold,
Review comment:
so you don't need to add `DSN_DEFINE_validator` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
