Smityz commented on a change in pull request #722:
URL: https://github.com/apache/incubator-pegasus/pull/722#discussion_r619764949
##########
File path: src/base/pegasus_value_schema.h
##########
@@ -238,13 +238,24 @@ class pegasus_value_generator
enum data_version
{
+ VERSION_0 = 0,
+ VERSION_COUNT,
+ VERSION_MAX = VERSION_0,
/// TBD(zlw)
};
struct value_params
{
+ value_params(std::string &buf, std::vector<rocksdb::Slice> &slices)
+ : write_buf(buf), write_slices(slices)
+ {
+ }
+
std::map<value_field_type, std::unique_ptr<value_field>> fields;
Review comment:
Maybe we can replace it with `std::array" to get more efficiency by both
time complexity(O(logN) vs O(1)) and [cache-friendly
](https://stackoverflow.com/questions/16699247/what-is-a-cache-friendly-code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
