neverchanje commented on a change in pull request #899:
URL: https://github.com/apache/incubator-pegasus/pull/899#discussion_r805519292
##########
File path: src/CMakeLists.txt
##########
@@ -15,7 +15,14 @@
# specific language governing permissions and limitations
# under the License.
-cmake_minimum_required(VERSION 3.5.2)
+cmake_minimum_required(VERSION 3.11.0)
+
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+ # require at least gcc 5.4.0
+ if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.4.0)
Review comment:
you guys can be more aggressive to allow only gcc7 actually, since you
have bundled gcc already.
Higher gcc version doesn't mean less adoption you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
