foreverneverer commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r951243614


##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
     result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
     result = 31 * result + (enableWriteLimit ? 1 : 0);
     result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
-    result = 31 * result + authProtocol.hashCode();

Review Comment:
   @acelyc111 
   
   I remember github will show message and suggest merge master latest code if 
pr behind master, but recent, this feature seem to be closed? 
   
   Keep latest code base master before merging is necessary, I think we should 
revert the feature as above. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org

Reply via email to