+1 (non-binding)

--
Best wishes,
Dan

On Sun, Oct 2, 2022 at 2:56 AM Liang Chen <[email protected]> wrote:

> +1(binding)
>
> I checked:
>
> - incubating in name, all source files have ASF headers
>
> - signatures and hashes are ok
>
> - LICENSE and NOTICE are ok
>
> - No binary files
>
> Regards
> Liang
>
> Yingchun Lai <[email protected]> 于2022年10月1日周六 18:25写道:
>
> > +1 (binding)
> >
> > I checked:
> >
> > (yes) Do release files have the word incubating in their name?
> >
> > (yes) Are the digital signatures and hashes correct?
> >
> > (yes) Does a DISCLAIMER file exist?
> >
> > (yes) Do LICENSE and NOTICE files exist?
> >
> > (yes) Is the LICENSE and NOTICE text correct?
> >
> > (yes) Is the NOTICE year correct?
> >
> > (no) Un-included software dependencies are not mentioned in LICENSE or
> > NOTICE?
> >
> > (no) License information is not mentioned in NOTICE?
> >
> > (yes) Is there any 3rd party code contained inside the release? If so:
> >
> > (yes) Does the software have a compatible license?
> >
> > (yes) Are all software licenses mentioned in LICENSE?
> >
> > (yes) Is the full text of the licenses (or pointers to it) in LICENSE?
> >
> > (yes) Is any of this code Apache-licensed? If so:
> >
> >   (yes) Do all source files have ASF headers?
> >
> >   (no) Do they have NOTICE files? If so:
> >
> >       (-) Have relevant parts of those NOTICE files been added to this
> > NOTICE file?
> >
> > (yes) Do the contents of the release match with what's tagged in version
> > control?
> >
> > (no) Are there any unexpected binary files in the release?
> >
> > (yes) Can you compile from source? Are the instructions clear?
> >
> > There are some typos, v2.4.0-RC2, in your mail content, but I think it
> > doesn't matter, I checked the actual artifact path and git tag are
> correct.
> > Another TODO thing is the official website should be upgraded, for
> example,
> > use English as the default language, the build instructions are out of
> > date, and etc, I will update it later.
> >
> > Best regards,
> > Yingchun Lai
> >
> >
> > On Sat, Oct 1, 2022 at 8:41 PM Jia Shuo <[email protected]> wrote:
> >
> > > Hello, Pegasus devs!
> > >
> > > The Pegasus team is happy to announce the Apache Pegasus 2.4.0-RC3.
> > >
> > > Apache Pegasus 2.4.0 is a feature release that offers many features and
> > > improvements since the prior release.
> > >
> > > This is a source-only release, some related link:
> > >
> > > The artifacts have been staged here: <
> > > https://dist.apache.org/repos/dist/dev/incubator/pegasus/2.4.0-RC2>
> > > dist - Revision 57124: /dev/incubator/pegasus/2.4.0-RC3 (apache.org)<
> > > https://dist.apache.org/repos/dist/dev/incubator/pegasus/2.4.0-RC3/>
> > >
> > > It is tagged in Git as v2.4.0-RC2 on GitHub:
> > > apache/incubator-pegasus at v2.4.0-RC3 (github.com)<
> > > https://github.com/apache/incubator-pegasus/tree/v2.4.0-RC3>
> > >
> > > The corresponding hash is the following:
> > > ASF Git Repos - incubator-pegasus.git/commit (apache.org)<
> > >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-pegasus.git;a=commit;h=8bdca79a7f871e91283bd0270e5bd7913d8c295e
> > > >
> > >
> > > The KEYS file to verify the artifact signatures can be found here:
> > > https://dist.apache.org/repos/dist/dev/incubator/pegasus/KEYS
> > >
> > > The WIP release notes can be found here:
> > >
> >
> https://docs.google.com/document/d/1zzHT-AmDfp6fXZN4-80Mv5_8eNi4wjpLZd4v_K02wFY/edit#heading=h.2ozarc20gnha
> > >
> > > You can validate the release by refering to Validating a staged
> release -
> > > PEGASUS - Apache Software Foundation<
> > >
> >
> https://cwiki.apache.org/confluence/display/PEGASUS/Validating+a+staged+release
> > > >
> > >
> > > ------
> > >
> > > Expecting your comments and votes.
> > > Thanks,
> > > Shuo Jia
> > >
> > >
> >
>

Reply via email to