acelyc111 commented on code in PR #1205:
URL:
https://github.com/apache/incubator-pegasus/pull/1205#discussion_r1006431104
##########
src/redis_protocol/proxy_lib/redis_parser.cpp:
##########
@@ -369,7 +368,7 @@ void redis_parser::reply_all_ready()
std::vector<dsn::message_ex *> ready_responses;
fetch_and_dequeue_messages(ready_responses, true);
for (dsn::message_ex *m : ready_responses) {
- dassert(m != nullptr, "");
+ CHECK(m, "");
Review Comment:
Added a new macro `CHECK_NOTNULL` for pointers, similar to [glog
CHECK_NOTNULL](https://github.com/google/glog/blob/b70ea80433c2a8f20b832be97b90f1f82b0d29e9/src/glog/logging.h.in#L945)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
