WHBANG commented on code in PR #1318:
URL:
https://github.com/apache/incubator-pegasus/pull/1318#discussion_r1073850685
##########
src/replica/replica_learn.cpp:
##########
@@ -1227,22 +1213,19 @@ error_code
replica::handle_learning_succeeded_on_primary(::dsn::rpc_address node
{
auto it = _primary_states.learners.find(node);
if (it == _primary_states.learners.end()) {
- LOG_ERROR("%s: handle_learning_succeeded_on_primary[%016" PRIx64 "]:
learner = %s, "
- "learner not found on primary, return ERR_LEARNER_NOT_FOUND",
- name(),
- learn_signature,
- node.to_string());
+ LOG_ERROR_PREFIX("handle_learning_succeeded_on_primary[{:#018x}]:
learner = {}, learner "
+ "not found on primary, return ERR_LEARNER_NOT_FOUND",
+ learn_signature,
+ node);
return ERR_LEARNER_NOT_FOUND;
}
if (it->second.signature != (int64_t)learn_signature) {
- LOG_ERROR("%s: handle_learning_succeeded_on_primary[%016" PRIx64 "]:
learner = %s, "
- "signature not matched, current signature on primary is
[%016" PRIx64
- "], return ERR_INVALID_STATE",
- name(),
- learn_signature,
- node.to_string(),
- it->second.signature);
+ LOG_ERROR_F("handle_learning_succeeded_on_primary[{:#018x}]: learner =
{}, signature not "
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
