acelyc111 commented on code in PR #1356: URL: https://github.com/apache/incubator-pegasus/pull/1356#discussion_r1112720090
########## docker/pegasus-build-env/centos6/Dockerfile: ########## @@ -76,12 +76,6 @@ ENV MAVEN_HOME=/opt/rh/rh-maven33/root/usr/ ENV PATH=$MAVEN_HOME/bin:$JAVA_HOME/bin:$GCC_HOME/bin:$PYTHON2_HOME/bin/:$PATH ENV LD_LIBRARY_PATH=$JAVA_HOME/jre/lib/amd64/server:$PYTHON2_HOME/lib64/:$LD_LIBRARY_PATH -RUN pip install --no-cache-dir cmake - -RUN wget --progress=dot:giga https://github.com/apache/thrift/archive/refs/tags/0.11.0.tar.gz -P /opt/thrift && \ Review Comment: thrift is used to generate cpp/java code from IDL, why removed it? ########## docker/pegasus-build-env/centos7/Dockerfile: ########## @@ -54,21 +54,21 @@ RUN yum -y install centos-release-scl \ yum clean all; \ rm -rf /var/cache/yum; -RUN pip3 install --no-cache-dir cmake +RUN pip3 install --upgrade pip --no-cache-dir && pip3 install --no-cache-dir cmake RUN wget --progress=dot:giga https://archive.apache.org/dist/maven/maven-3/3.8.3/binaries/apache-maven-3.8.3-bin.tar.gz -P /opt/maven \ && cd /opt/maven \ && tar -zxf apache-maven-3.8.3-bin.tar.gz \ && rm apache-maven-3.8.3-bin.tar.gz +ENV JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk Review Comment: What issue to solve by reordering? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
