WHBANG commented on code in PR #1379:
URL:
https://github.com/apache/incubator-pegasus/pull/1379#discussion_r1124349349
##########
src/runtime/security/access_controller.cpp:
##########
@@ -26,11 +26,22 @@
namespace dsn {
namespace security {
DSN_DEFINE_bool(security, enable_acl, false, "whether enable access controller
or not");
-DSN_TAG_VARIABLE(enable_acl, FT_MUTABLE);
-DSN_DEFINE_string(security, super_users, "", "super user for access
controller");
+DSN_DEFINE_bool(security, enable_ranger_acl, false, "whether enable access
controller or not");
-access_controller::access_controller() { utils::split_args(FLAGS_super_users,
_super_users, ','); }
+DSN_DEFINE_string(security,
+ super_users,
+ "",
Review Comment:
except for the rpc registered in the `allowed_list`, other RPCs need to be
accessed through user_name .(user_name=principal_name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
