Apache9 commented on code in PR #1393:
URL:
https://github.com/apache/incubator-pegasus/pull/1393#discussion_r1136848064
##########
java-client/src/main/java/org/apache/pegasus/security/KerberosProtocol.java:
##########
@@ -53,7 +54,18 @@ class KerberosProtocol implements AuthProtocol {
private String keyTab;
private String principal;
final int CHECK_TGT_INTEVAL_SECONDS = 10;
- final ScheduledExecutorService service =
Executors.newSingleThreadScheduledExecutor();
+ final ScheduledExecutorService service =
+ Executors.newSingleThreadScheduledExecutor(new TgtThreadFactory());
+
+ static class TgtThreadFactory implements ThreadFactory {
Review Comment:
Just create an anonymous class is enough?
##########
java-client/src/main/java/org/apache/pegasus/security/KerberosProtocol.java:
##########
@@ -161,19 +173,16 @@ private static Configuration
getLoginContextConfiguration(String keyTab, String
@Override
public AppConfigurationEntry[] getAppConfigurationEntry(String name) {
Map<String, String> options = new HashMap<>();
- // TGT is obtained from the ticket cache.
- options.put("useTicketCache", "true");
Review Comment:
This is for keytab based login so we should remove useTicketCache, but do we
support login use ticket cache? There is another method for ticker cache based
login?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
