empiredan commented on code in PR #1388:
URL:
https://github.com/apache/incubator-pegasus/pull/1388#discussion_r1139706646
##########
src/runtime/ranger/ranger_resource_policy_manager.h:
##########
@@ -73,20 +76,56 @@ class ranger_resource_policy_manager
static void parse_policies_from_json(const rapidjson::Value &data,
std::vector<policy_item> &policies);
+ // Update policies from Ranger service.
+ dsn::error_code update_policies_from_ranger_service();
+
+ // Pull policies in JSON format from Ranger service.
+ dsn::error_code pull_policies_from_ranger_service(std::string
*ranger_policies) const;
Review Comment:
Could `pull_policies_from_ranger_service` be defined in anonymous namespace
in cpp file since it does not reference any members ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
