acelyc111 commented on code in PR #1418:
URL:
https://github.com/apache/incubator-pegasus/pull/1418#discussion_r1151326906
##########
src/server/pegasus_service_app.h:
##########
@@ -57,11 +59,13 @@ class pegasus_replication_service_app : public
::dsn::replication::replication_s
::dsn::error_code ret =
::dsn::replication::replication_service_app::stop();
if (_updater_started) {
pegasus_counter_reporter::instance().stop();
+ _builtin_metrics.stop();
}
return ret;
}
private:
+ dsn::builtin_metrics _builtin_metrics;
bool _updater_started;
Review Comment:
If pegasus_counter_reporter and builtin_metrics are both common objects, and
they can stop automatically, _updater_started can be removed?
##########
src/server/pegasus_service_app.h:
##########
@@ -47,6 +48,7 @@ class pegasus_replication_service_app : public
::dsn::replication::replication_s
if (ret == ::dsn::ERR_OK) {
pegasus_counter_reporter::instance().start();
Review Comment:
It's strange a singleton to explicit start, we can improve it later, define
it as a common object too?
##########
src/utils/builtin_metrics.cpp:
##########
@@ -0,0 +1,93 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "utils/builtin_metrics.h"
+
+#include <stdint.h>
+#include <functional>
+
+#include "utils/autoref_ptr.h"
+#include "utils/flags.h"
+#include "utils/fmt_logging.h"
+#include "utils/process_utils.h"
+#include "utils/string_view.h"
+
+METRIC_DEFINE_gauge_int64(server,
+ virtual_mem_usage_mb,
+ dsn::metric_unit::kMegaBytes,
+ "The total amount of virtual memory usage in MB");
+
+METRIC_DEFINE_gauge_int64(server,
+ resident_mem_usage_mb,
+ dsn::metric_unit::kMegaBytes,
+ "The total amount of physical memory usage in MB");
+
+namespace dsn {
+
+DSN_DEFINE_uint64(metrics,
+ builtin_metrics_update_interval_ms,
+ 10 * 1000,
+ "The interval (milliseconds) at which builtin metrics are
updated.");
+
+builtin_metrics::builtin_metrics()
+ : METRIC_VAR_INIT_server(virtual_mem_usage_mb),
METRIC_VAR_INIT_server(resident_mem_usage_mb)
+{
+}
+
+builtin_metrics::~builtin_metrics() { stop(); }
+
+void builtin_metrics::on_close() {}
+
+void builtin_metrics::start()
+{
+ if (_timer) {
Review Comment:
So it must be a bug if start builtin_metrics multiple times, how about just
CHECK `_timer` must be null when start?
##########
src/utils/builtin_metrics.cpp:
##########
@@ -0,0 +1,93 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "utils/builtin_metrics.h"
+
+#include <stdint.h>
+#include <functional>
+
+#include "utils/autoref_ptr.h"
+#include "utils/flags.h"
+#include "utils/fmt_logging.h"
+#include "utils/process_utils.h"
+#include "utils/string_view.h"
+
+METRIC_DEFINE_gauge_int64(server,
+ virtual_mem_usage_mb,
+ dsn::metric_unit::kMegaBytes,
+ "The total amount of virtual memory usage in MB");
+
+METRIC_DEFINE_gauge_int64(server,
+ resident_mem_usage_mb,
+ dsn::metric_unit::kMegaBytes,
+ "The total amount of physical memory usage in MB");
+
+namespace dsn {
+
+DSN_DEFINE_uint64(metrics,
+ builtin_metrics_update_interval_ms,
+ 10 * 1000,
+ "The interval (milliseconds) at which builtin metrics are
updated.");
+
+builtin_metrics::builtin_metrics()
+ : METRIC_VAR_INIT_server(virtual_mem_usage_mb),
METRIC_VAR_INIT_server(resident_mem_usage_mb)
+{
+}
+
+builtin_metrics::~builtin_metrics() { stop(); }
+
+void builtin_metrics::on_close() {}
+
+void builtin_metrics::start()
+{
+ if (_timer) {
+ return;
+ }
+
+ _timer.reset(new metric_timer(FLAGS_builtin_metrics_update_interval_ms,
+ std::bind(&builtin_metrics::update, this),
+ std::bind(&builtin_metrics::on_close,
this)));
+}
+
+void builtin_metrics::stop()
+{
+ if (!_timer) {
Review Comment:
Same, in which case builtin_metrics will be stopped multiple times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
