empiredan commented on code in PR #1435: URL: https://github.com/apache/incubator-pegasus/pull/1435#discussion_r1165265711
########## src/meta/table_metrics.cpp: ########## @@ -17,12 +17,54 @@ #include "table_metrics.h" +// IWYU pragma: no_include <ext/alloc_traits.h> #include <fmt/core.h> +#include <fmt/ostream.h> +#include <stddef.h> +#include <iosfwd> #include <string> #include "utils/fmt_logging.h" #include "utils/string_view.h" +METRIC_DEFINE_entity(partition); + +METRIC_DEFINE_counter(partition, + partition_configuration_changes, + dsn::metric_unit::kChanges, + "The number of times the configuration has been changed"); + +METRIC_DEFINE_counter(partition, + unwritable_partition_changes, + dsn::metric_unit::kChanges, + "The number of times the status of partition has been changed to unwritable"); + +METRIC_DEFINE_counter(partition, + writable_partition_changes, + dsn::metric_unit::kChanges, + "The number of times the status of partition has been changed to writable"); + +METRIC_DEFINE_gauge_int64( + partition, + greedy_recent_balance_operations, Review Comment: Yes, actually this metric is updated after a batch of balance operations. Thus it is `recent`. Also, it is somewhat special. It could be either the number of balance operations that have been executed, or the number of balance operations that would be executed in the future. As a result it can only be declared as gauge rather than counter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
