empiredan commented on code in PR #1455:
URL:
https://github.com/apache/incubator-pegasus/pull/1455#discussion_r1171041120
##########
src/replica/replica.h:
##########
@@ -284,7 +284,7 @@ class replica : public serverlet<replica>, public
ref_counter, public replica_ba
//
// Statistics
//
- void update_commit_qps(int count);
+ METRIC_DECLARE_INCREMENT_BY(committed_requests, );
Review Comment:
OK, `committed_requests` will be moved to replica-level and maintained in
`replication_app_base`, which is more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
