acelyc111 commented on code in PR #1463:
URL:
https://github.com/apache/incubator-pegasus/pull/1463#discussion_r1184958232
##########
src/replica/replica_stub.cpp:
##########
@@ -2901,7 +2895,7 @@ uint64_t replica_stub::gc_tcmalloc_memory(bool
release_all)
release_bytes -= 1024 * 1024;
}
}
- _counter_tcmalloc_release_memory_size->set(tcmalloc_released_bytes);
+ METRIC_VAR_SET(tcmalloc_released_bytes, tcmalloc_released_bytes);
Review Comment:
@empiredan As we discuss offline, `tcmalloc_released_bytes` is better to be
a counter type, we can improve it in next patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
