levy5307 commented on code in PR #1477:
URL:
https://github.com/apache/incubator-pegasus/pull/1477#discussion_r1201886296
##########
src/common/fs_manager.cpp:
##########
@@ -80,6 +87,11 @@ uint64_t dir_node::replicas_count(app_id id) const
return iter->second.size();
}
+std::string dir_node::replica_dir(const char *app_type, const dsn::gpid &pid)
const
Review Comment:
Could you change the type of `app_type` to `string_view`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
