empiredan opened a new issue, #1490:
URL: https://github.com/apache/incubator-pegasus/issues/1490

   While querying the metrics of new framework, some metric units showed 
"Unknown" as follows:
   ```json
       {
           "type": "replica",
           "id": "replica_6.1",
           "attributes": {
               "partition_id": "1",
               "table_id": "6"
           },
           "metrics": [
               {
                   "type": "counter",
                   "name": "corrupt_writes",
                   "unit": "requests",
                   "desc": "The number of corrupt writes for each replica",
                   "value": 0
               },
               {
                   "type": "counter",
                   "name": "backup_request_bytes",
                   "unit": "Unknown",
                   "desc": "The number of bytes for backup requests",
                   "value": 0
               },
               {
                   "type": "counter",
                   "name": "check_and_mutate_bytes",
                   "unit": "Unknown",
                   "desc": "The number of bytes for CHECK_AND_MUTATE requests",
                   "value": 0
               },
               {
                   "type": "counter",
                   "name": "dup_lagging_writes",
                   "unit": "requests",
                   "desc": "the number of lagging writes (time lag larger than 
`dup_lagging_write_threshold_ms`)",
                   "value": 0
               },
               {
                   "type": "counter",
                   "name": "check_and_set_bytes",
                   "unit": "Unknown",
                   "desc": "The number of bytes for CHECK_AND_SET requests",
                   "value": 0
               },
               {
                   "type": "percentile",
                   "name": "dup_time_lag_ms",
                   "unit": "milliseconds",
                   "desc": "the time lag (in ms) between master and slave in 
the duplication",
                   "p50": 0,
                   "p90": 0,
                   "p95": 0,
                   "p99": 0,
                   "p999": 0
               },
               {
                   "type": "counter",
                   "name": "multi_put_bytes",
                   "unit": "Unknown",
                   "desc": "The number of bytes for MULTI_PUT requests",
                   "value": 0
               },
               ...
           ],
           ...
       }
   ```
   
   The reason is that `enum_to_string` are forgotten to be added for some 
metric units.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to